Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.4: Fix snapshotRef checks #358

Merged
merged 1 commit into from
Oct 17, 2019
Merged

0.4: Fix snapshotRef checks #358

merged 1 commit into from
Oct 17, 2019

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Oct 8, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixed checking of binding of PVC and Snapshots when creating volumes.

Does this PR introduce a user-facing change?:

Added extra verification of source Snapshot before provisioning.

/assign @msau42

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 8, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2019
@jsafrane jsafrane force-pushed the 0.4-claimref-checks branch from 946a99c to 2bb7c70 Compare October 17, 2019 07:15
@msau42
Copy link
Collaborator

msau42 commented Oct 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9a63269 into kubernetes-csi:release-0.4 Oct 17, 2019
@msau42 msau42 mentioned this pull request Nov 14, 2019
Closed
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
@k8s-ci-robot
Merge pull request kubernetes-csi#358 from Kartik494/emptydefaultfs
438ddbd 
Change Fstype default to emptyString from ext4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@sbezverk sbezverk Awaiting requested review from sbezverk

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsafrane @k8s-ci-robot @msau42