-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore non-migrated in-tree PVC when provisioning #345
Conversation
@pohly do you know why test-subtree is failing in travis but not prow? I'm inclined to just disable travis PR on all our repos. prow unit job should have all the same functionality right? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
I disabled travis PR testing, but we may have to manually merge this one |
That was fun to investigate. I couldn't reproduce it initially, even after compiling the same git version that TravisCI uses. But then the Shallow clones are problematic. For example, We can:
The last option would be the fastest and doesn't depend on updating csi-release-tools. |
Hmm having image tag build potentially fail is not great either. I'm going to re-enable travis and let's try the method to add one more commit to this pr? |
Once we are able to migrate image releasing to prow, then we can disable travis altogether |
/lgtm |
…te_OWNERS_files_-_remove_sections_about_emeritus_reviewers Validate OWNERS files - remove sections about emeritus reviewers
Cherry-pick of: #341
/kind bug
/assign @jsafrane @msau42
/cc @ddebroy @leakingtapan