Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for migration #343

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Unit tests for migration #343

merged 1 commit into from
Oct 9, 2019

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Sep 12, 2019 •
edited
Loading

/kind cleanup

This PR adds unit tests for CSI Migration. The code should work and is ready for review

/assign @msau42 @jsafrane @ddebroy
/cc @ddebroy @leakingtapan @shanesiebken

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 12, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2019
@k8s-ci-robot
Copy link
Contributor

@davidz627: GitHub didn't allow me to request PR reviews from the following users: shanesiebken.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/kind cleanup

This PR adds a unit test for CSI Migration. The code should work and is ready for review

/assign @msau42 @jsafrane @ddebroy

TODO

[ ] Make the translation library change in k8s/k8s and vendor in change to provisioner

/cc @ddebroy @leakingtapan @shanesiebken

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2019
This was referenced Sep 13, 2019
Merged
Merged
misterikkit
misterikkit reviewed Sep 16, 2019
View reviewed changes
pkg/controller/util.go Outdated Show resolved Hide resolved
pkg/controller/util.go Outdated Show resolved Hide resolved
pkg/controller/util.go Outdated Show resolved Hide resolved
pkg/controller/util.go Outdated Show resolved Hide resolved
pkg/controller/util.go Outdated Show resolved Hide resolved
pkg/controller/util.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2019
@davidz627 davidz627 changed the title WIP Unit tests for migration Unit tests for migration Sep 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2019
@davidz627
Copy link
Contributor Author

/assign @ddebroy @leakingtapan
ping @misterikkit
this PR is ready for review

ddebroy
ddebroy reviewed Oct 4, 2019
View reviewed changes
Copy link
Collaborator

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Otherwise lgtm. Thanks for adding the unit tests!

pkg/controller/controller_test.go Outdated Show resolved Hide resolved
@davidz627 davidz627 force-pushed the tests/migrationUnit branch from 26c2d16 to e6ea6b5 Compare October 4, 2019 20:25
misterikkit
misterikkit reviewed Oct 8, 2019
View reviewed changes
Copy link

@misterikkit misterikkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darn, I just accidentally deleted some draft comments. Better send these now.

pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
vendor/k8s.io/csi-translation-lib/translate.go Outdated Show resolved Hide resolved
vendor/k8s.io/csi-translation-lib/translate.go Outdated Show resolved Hide resolved
vendor/k8s.io/csi-translation-lib/plugins/openstack_cinder.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/translator.mock.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
@davidz627 davidz627 force-pushed the tests/migrationUnit branch 4 times, most recently from 0e23f05 to 4f4a86b Compare October 8, 2019 23:42
misterikkit
misterikkit reviewed Oct 9, 2019
View reviewed changes
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Show resolved Hide resolved
pkg/controller/controller_test.go Show resolved Hide resolved
pkg/controller/controller_test.go
Comment on lines +3178 to +3169
defer mockController.Finish()
defer driver.Stop()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ordering matter between Finish() and Stop()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure - this is how every other test does it.

pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/controller_test.go Outdated Show resolved Hide resolved
@davidz627 davidz627 force-pushed the tests/migrationUnit branch 3 times, most recently from 51689da to 91ee105 Compare October 9, 2019 20:41
@davidz627 davidz627 force-pushed the tests/migrationUnit branch from 91ee105 to 526176f Compare October 9, 2019 21:20
misterikkit
misterikkit approved these changes Oct 9, 2019
View reviewed changes
Copy link

@misterikkit misterikkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@msau42
Copy link
Collaborator

msau42 commented Oct 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 97bb3fd into kubernetes-csi:master Oct 9, 2019
@davidz627 davidz627 deleted the tests/migrationUnit branch October 9, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy ddebroy left review comments

@misterikkit misterikkit misterikkit approved these changes

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@jsafrane jsafrane

@misterikkit misterikkit

@leakingtapan leakingtapan

@ddebroy ddebroy

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@davidz627 @k8s-ci-robot @msau42 @misterikkit @ddebroy @jsafrane @leakingtapan