Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] Cherry pick: Retry provisioning of volumes after transient error #320

Closed
wants to merge 1 commit into from
Closed

[1.1] Cherry pick: Retry provisioning of volumes after transient error #320

wants to merge 1 commit into from

Conversation

jsafrane
Copy link
Contributor

This is cherry-pick of #312 into 1.1

The provisioner should retry CreateVolume call after a transient error
(such as timeout), because the CSI driver may be creating a volume in the
background.

Therefore ProvisionerExt interface need to be implemented. ProvisionExt()
returns:

  • Finished, if it can be 100% sure that the driver is not creating a volume
  • NoChange, if something (temporarily?) failed before reaching the CSI
    driver, for example when Kubernetes API server is not reachable.
  • InBackground, if error returned by the driver (or gRPC) is transient.
Fixed potential leak of volumes after CSI driver timeouts.

@jsafrane
Retry provisioning of volumes after transient error
366740a 
The provisioner should retry CreateVolume call after a transient error
(such as timeout), because the CSI driver may be creating a volume in the
background.

Therefore ProvisionerExt interface need to be implemented. ProvisionExt()
returns:

- Finished, if it can be 100% sure that the driver is not creating a volume
- NoChange, if something (temporarily?) failed before reaching the CSI
  driver, for example when Kubernetes API server is not reachable.
- InBackground, if error returned by the driver (or gRPC) is transient.
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali July 17, 2019 11:52
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2019
@jsafrane jsafrane changed the title [1.2] Cherry pick: Retry provisioning of volumes after transient error [1.1] Cherry pick: Retry provisioning of volumes after transient error Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

@jsafrane: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-provisioner-1-15-on-kubernetes-1-15 366740a link /test pull-kubernetes-csi-external-provisioner-1-15-on-kubernetes-1-15
pull-kubernetes-csi-external-provisioner-1-14-on-kubernetes-1-14 366740a link /test pull-kubernetes-csi-external-provisioner-1-14-on-kubernetes-1-14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msau42
Copy link
Collaborator

msau42 commented Jul 17, 2019

Looks like we need to update release tools for 1.1 branch like #315

@pohly
Copy link
Contributor

pohly commented Jul 17, 2019

Looks like we need to update release tools for 1.1 branch like #315

Isn't the release-1.1 branch unmaintained now because we don't need that version of the external-provisioner for anything? At least that's what I thought and therefore I hadn't created a csi-release-tools PR for that branch.

According to https://kubernetes-csi.github.io/docs/external-provisioner.html we currently need release-1.0 (for Kubernetes 1.13), release-1.2 (for 1.14) and release-1.3 (for 1.15).

@jsafrane
Copy link
Contributor Author

Sorry for the noise
/close

@k8s-ci-robot
Copy link
Contributor

@jsafrane: Closed this PR.

In response to this:

Sorry for the noise
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor Author

Just for the reference, there is no ProvisionerExt interface in 1.0.1, so this PR does not need to be backported there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsafrane @k8s-ci-robot @msau42 @pohly