Add comment about deletion #275
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
|
/assign @msau42 |
Signed-off-by: Deep Debroy <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ddebroy If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
| @@ -20,6 +20,7 @@ | |||
| `--leader-election-type=leases` ([#261](https://github.com/kubernetes-csi/external-provisioner/pull/261)) | |||
|
|
|||
| ## Other Notable Changes | |||
| * Handle deletion of volumes associated with in-tree plugins that are migrated to CSI ([#273](https://github.com/kubernetes-csi/external-provisioner/pull/273)) | |||
There was a problem hiding this comment.
Can you add this in a new section
'''
Changes since 1.1.0
'''
Actually, can you cherry pick the fix to release-1.1 branch and then make the changelog PR in that branch?
There was a problem hiding this comment.
Cherry pick PR opened at #276
There was a problem hiding this comment.
we should still merge this into master right?
There was a problem hiding this comment.
For the next 1.2.0, we'll probably have a new release notes generation tool that can populate this
There was a problem hiding this comment.
closing for now then.
…-master Update release tools
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Update release notes to reflect changes to support deletion of CSI migrated volumes.
Which issue(s) this PR fixes:
Fixes # #273 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: