Topology support #141
Topology support #141
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/XXL
pkg/controller/controller.go
Outdated
| return rsp.GetCapabilities(), nil | ||
| } | ||
|
|
||
| func supportsPluginControllerService(capabilities []*csi.PluginCapability) bool { |
There was a problem hiding this comment.
You could have one helper method that searches capabilities for the passed in service
pkg/controller/controller.go
Outdated
| if err != nil { | ||
| glog.Errorf("failed to get support info :%v", err) | ||
| return "", err | ||
| glog.Errorf("failed to get plugin capabilities: %v", err) |
There was a problem hiding this comment.
This should be handled as a separate pr, but I want to get rid of this style of logging errors that we're also returning
There was a problem hiding this comment.
I'll address it in this PR. Improving the code base one line at a time :)
pkg/controller/controller.go
Outdated
| @@ -90,6 +90,11 @@ type csiProvisioner struct { | |||
| config *rest.Config | |||
| } | |||
|
|
|||
| type driverState struct { | |||
| driverName string | |||
| accessibilityConstraintCapability bool | |||
There was a problem hiding this comment.
a more clear name could be "supportsAccessiblity"
There was a problem hiding this comment.
or you could potentially make this generic and have an enum of all the different capabilities
verult
force-pushed
the
final-top
branch
9 times, most recently
from
87991fd to
8a083d0
Compare
|
All the core functionality and the vast majority of core testing is complete. Reviewers PTAL. I'll add StatefulSet spreading in a separate PR post k8s 1.12 release since it's an optimization. Working on the TODOs left in the PR but I'll hold off on pushing mode code for now until we get a critical mass of reviews |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Added backoff parameters to external attacher
Creating a PR for early review.
I have a local working prototype. The hope is each of these PRs introduce a feature whose implementation is as close to the final form as possible.
@jsafrane @msau42 @saad-ali @ddebroy
Features (some of these need more refinement but core logic is there):