Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: remove protection finalizer correctly #1245

Closed
wants to merge 1 commit into from
Closed

WIP: remove protection finalizer correctly #1245

wants to merge 1 commit into from

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Jul 29, 2024 •
edited
Loading

Bump sig-storage-lib-external-provisioner to remove PV protection finalizer correctly.

WIP: waiting for kubernetes-sigs/sig-storage-lib-external-provisioner#174 to be merged firs & v10.0.1 tagged.

A testing image is available as quay.io/jsafrane/external-provisioner:test1245 (amd64 only)

Fixed removal of PV protection finalizer. PVs are no longer Terminating forever after PVC deletion.

@jsafrane
WIP: remove protection finalizer correctly
9205d36 
Bump sig-storage-lib-external-provisioner to remove PV protection finalizer
correctly.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ggriffiths July 29, 2024 12:54
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang July 29, 2024 12:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2024
@jsafrane jsafrane mentioned this pull request Jul 29, 2024
Closed
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 8, 2024

This is already done in #1250
/close

@k8s-ci-robot
Copy link
Contributor

@jsafrane: Closed this PR.

In response to this:

This is already done in #1250
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsafrane @k8s-ci-robot