Fix clone controller shallow copy bug

[1978629634]

What type of PR is this?

/kind bug

What this PR does / why we need it:

If the cloner controller directly updates the PVC reference without using a deep copy and then calls the Update() method, it can lead to a situation where the cached PVC is updated (removing the finalizer), while the actual PVC remains unmodified in case the Update() operation fails.

Which issue(s) this PR fixes:

Fixes #1188

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix clone controller shallow copy bug

[k8s-ci-robot]

Hi @1978629634. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[1978629634]

@pohly Would you mind reviewing this PR for me? I value your expertise and feedback.

[1978629634]

Hi @RaunakShah @xing-yang, Could you please take a look at this pull request when you have a chance? I'd appreciate your review and feedback.

[jsafrane]

/ok-to-test

[jsafrane]

Thanks!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 1978629634, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment