-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CSI secret handling logic reusable #653
Comments
Do you have preference on where the codes should move to? |
Snapshotter codes seem to share the similar logic with different keys. It looks cleaner to move it to a separate repo. Any thought? |
https://github.com/kubernetes-csi/csi-lib-utils is the place we've been putting libraries shared by multiple components |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CSI secret can be defined as a template as defined here. Current implementation of external-provisioner embeds this logic in the controller codes as private scoped, which isn't reusable from other controllers.
There are use cases, like PVC transfer and secret protection, to use this logic from other controllers, therefore it needs to be changed to public scoped and move to a kind of util packages.
The text was updated successfully, but these errors were encountered: