feature: remove agent logic from external-health-monitor

[fengzixu]

What type of PR is this?

/kind feature
What this PR does / why we need it:

1. remove agent logic of external-health-monitor-agent

Which issue(s) this PR fixes:

Fixes #57

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- remove the logic of external-health-monitor-agent due to they are moved to kubelet

[NickrenREN]

Should we wait some time and do this when the agent logic in kubelet goes to beta ?

[NickrenREN]

/hold

[xing-yang]

Should we wait some time and do this when the agent logic in kubelet goes to beta ?

Probably makes sense. In that case, we should disable the agent logic and not to release a new image for it.

[xing-yang]

Let's put this PR on-hold until CSIVolumeHealth feature in Kubelet moves to Beta.

@fengzixu, can you submit another PR to disable the building of the agent image? I think just removing it from the Makefile will do. Thanks.
https://github.com/kubernetes-csi/external-health-monitor/blob/master/Makefile

[fengzixu]

Let's put this PR on-hold until CSIVolumeHealth feature in Kubelet moves to Beta.

@fengzixu, can you submit another PR to disable the building of the agent image? I think just removing it from the Makefile will do. Thanks.
https://github.com/kubernetes-csi/external-health-monitor/blob/master/Makefile

Done: #64

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[xing-yang]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[xing-yang]

/remove-lifecycle rotten

[xing-yang]

We moved agent logic to Kubelet in 1.21. In 1.24, we also added volume health as metrics in Kubelet and made a second Alpha. I think the agent logic should be removed from this repo so we don't have to maintain code in two places.

@NickrenREN What do you think?

[NickrenREN]

@xing-yang sorry for the late reply. Sound good to me

[xing-yang]

@fengzixu Can you update this PR?

[fengzixu]

Will fix the issue in test soon

[xing-yang]

/hold cancel

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengzixu, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment