fix pv health condition checker to iterate and check all the volumes in the list

[Praveenrajmani]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Currently the PVHealthConditionChecker will not iterate over all volumes in the list. It returns on the first iteration after sending the recovery event.

The events to PVCs will not be posted properly due to this bug

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix pv health condition checker to not miss PVC events

[k8s-ci-robot]

Welcome @Praveenrajmani!

It looks like this is your first PR to kubernetes-csi/external-health-monitor 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-health-monitor has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Praveenrajmani. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/ok-to-test

[xing-yang]

/assign @fengzixu

[xing-yang]

Please add a release note.

[fengzixu]

Good Catch. Thank you @Praveenrajmani . As @xing-yang commented, we could remove the return value of sendRecoveryEventToPVC function. Because our requirement is to make sure the recovery event can be sent as far as possible. I guess that's also reason that you want to have this PR to fix the current bug. This function will be periodically called(aka retry for failure case) until the controller is stopped.

In that case, could do you some changes on this PR and add the release note?

[Praveenrajmani]

In that case, could do you some changes on this PR and add the release note?

yeah, sure @fengzixu

[xing-yang]

@Praveenrajmani What I meant is to add a release-note in your PR description under "Does this PR introduce a user-facing change?". See this example here: #101

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Praveenrajmani, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment