Add a timeout to attach and detach calls #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsafrane
reviewed
Aug 1, 2018
pkg/controller/framework_test.go
Outdated
| calls []csiCall | ||
| index int | ||
| t *testing.T | ||
| delays []time.Duration |
There was a problem hiding this comment.
Can you add delay to csiCall struct? I find it odd to have two arrays that are supposed to have the same length. It also simplifies the handling a bit, you just add sleep after reflect.DeepEqual below.
There was a problem hiding this comment.
Unnamed structs are a pain to fix 😢
Signed-off-by: Luis Pabón <[email protected]>
|
/lgtm Thanks for taking over the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #52 plus tests
Fixes #51