Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CTDI CSI Support #559

Merged
merged 3 commits into from
May 1, 2023
Merged

add CTDI CSI Support #559

merged 3 commits into from
May 1, 2023

Conversation

ctdi-storage
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 18, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 18, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @ctdi-storage!

It looks like this is your first PR to kubernetes-csi/docs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/docs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 18, 2023
xing-yang
xing-yang reviewed Apr 20, 2023
View reviewed changes
book/src/drivers.md Outdated
@@ -32,6 +32,7 @@ Name | CSI Driver Name | Compatible with CSI Version(s) | Description | Persiste
[CubeFS](https://github.com/cubefs/cubefs-csi) | `csi.cubefs.com` | v1.1.0 | A Container Storage Interface (CSI) Driver for CubeFS Storage | Persistent | Read/Write Multiple Pods | Yes |
[Cinder](https://github.com/kubernetes/cloud-provider-openstack/tree/master/pkg/csi/cinder) | `cinder.csi.openstack.org` | v0.3, v1.0, v1.1.0, v1.2.0, v1.3.0 | A Container Storage Interface (CSI) Driver for OpenStack Cinder | Persistent and Ephemeral | Depends on the storage backend used | Yes, if storage backend supports it | Raw Block, Snapshot, Expansion, Cloning, Topology
[cloudscale.ch](https://github.com/cloudscale-ch/csi-cloudscale) | `csi.cloudscale.ch` | v1.0 | A Container Storage Interface (CSI) Driver for the [cloudscale.ch](https://www.cloudscale.ch/) IaaS platform | Persistent | Read/Write Single Pod | Yes |Snapshot
[CTDI Block Storage](https://ctdi-storage.github.io/) | `csi.block.ctdi.com` | v1.0 | A Container Storage Interface (CSI) Driver for CTDI Distributed Block Storage | Persistent | Read/Write Single Pod | Yes | Raw Block, Snapshot, Expansion, Cloning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide an English version of Deployment instructions on the github? It is in Chinese now.
In the instruction steps, you mentioned a few yamls. Where do user find those yamls? Maybe I missed something here.
Also Column 3 is for supported CSI spec version, not CSI driver version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang I have uploaded the English version of Deployment instructions and updated the CSI spec version

xing-yang
xing-yang reviewed Apr 23, 2023
View reviewed changes
book/src/drivers.md Outdated
@@ -32,6 +32,7 @@ Name | CSI Driver Name | Compatible with CSI Version(s) | Description | Persiste
[CubeFS](https://github.com/cubefs/cubefs-csi) | `csi.cubefs.com` | v1.1.0 | A Container Storage Interface (CSI) Driver for CubeFS Storage | Persistent | Read/Write Multiple Pods | Yes |
[Cinder](https://github.com/kubernetes/cloud-provider-openstack/tree/master/pkg/csi/cinder) | `cinder.csi.openstack.org` | v0.3, v1.0, v1.1.0, v1.2.0, v1.3.0 | A Container Storage Interface (CSI) Driver for OpenStack Cinder | Persistent and Ephemeral | Depends on the storage backend used | Yes, if storage backend supports it | Raw Block, Snapshot, Expansion, Cloning, Topology
[cloudscale.ch](https://github.com/cloudscale-ch/csi-cloudscale) | `csi.cloudscale.ch` | v1.0 | A Container Storage Interface (CSI) Driver for the [cloudscale.ch](https://www.cloudscale.ch/) IaaS platform | Persistent | Read/Write Single Pod | Yes |Snapshot
[CTDI Block Storage](https://ctdi-storage.github.io/) | `csi.block.ctdi.com` | >=v1.0.0 | A Container Storage Interface (CSI) Driver for CTDI Distributed Block Storage | Persistent | Read/Write Single Pod | Yes | Raw Block, Snapshot, Expansion, Cloning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the doc, it says "You can obtain the deployment script through the CTDI CSI source code, located at ./deploy/block/kubernetes", but that link is the general link. I don't see the deployment yaml there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang
Sorry，I have updated the link，thanks for the information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column 3 is CSI spec version. You can't just say ">=v1.0.0" as you can't claim support for versions that don't exist yet. Please specify a concrete version. You can give a range if you support multiple versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang
thanks for your information, I have change the support spec version to range format

@coulof coulof mentioned this pull request Apr 26, 2023
Merged
@xing-yang
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 1, 2023
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ctdi-storage, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit df2b6f7 into kubernetes-csi:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@msau42 msau42 Awaiting requested review from msau42

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctdi-storage @k8s-ci-robot @xing-yang