Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI 0.2.0 breaking changes #40

Merged
merged 1 commit into from
Feb 9, 2018
Merged

CSI 0.2.0 breaking changes #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 9 additions & 111 deletions Gopkg.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

[[constraint]]
name = "github.com/container-storage-interface/spec"
version = "0.1.0"
branch = "master"

[[constraint]]
name = "github.com/golang/mock"
Expand Down
14 changes: 7 additions & 7 deletions driver/driver.mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion hack/e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ UDS="/tmp/e2e-csi-sanity.sock"
CSI_ENDPOINTS="127.0.0.1:9998"
CSI_ENDPOINTS="$CSI_ENDPOINTS unix://${UDS}"
CSI_ENDPOINTS="$CSI_ENDPOINTS ${UDS}"
CSI_MOCK_VERSION="support/csi-0.2.0"

#
# $1 - endpoint for mock.
Expand All @@ -23,7 +24,16 @@ runTest()
fi
}

go get -u github.com/thecodeteam/gocsi/mock
#
# TODO Once 0.2.0 change gets merged into gocsi repo, switch back to "go get"
#
git clone https://github.com/thecodeteam/gocsi $GOPATH/src/github.com/thecodeteam/gocsi
pushd $GOPATH/src/github.com/thecodeteam/gocsi
git checkout $CSI_MOCK_VERSION
make build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this copy it to $GOPATH/bin?

Copy link
Contributor Author

@sbezverk sbezverk Feb 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise e2e test would have failed.

popd
#
#go get -u github.com/thecodeteam/gocsi/mock
cd cmd/csi-sanity
make clean install || exit 1
cd ../..
Expand Down
Loading