Skip to content

Commit

Permalink
Remove --kube-root deprecated kind argument
Browse files Browse the repository at this point in the history
The --kube-root flag has been deprecated in kind for some time and will
be removed. The current equivalent functionality is to pass the path to
the kubernetes source as the first non-flag argument to "build
node-image".

This updates the prow script to use the newer preferred method in
preparation for kind dropping the flag.

Signed-off-by: Sean McGinnis <[email protected]>
  • Loading branch information
stmcginnis committed Dec 6, 2024
1 parent 734c2b9 commit faf79ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion prow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ start_cluster () {
go_version="$(go_version_for_kubernetes "${CSI_PROW_WORK}/src/kubernetes" "$version")" || die "cannot proceed without knowing Go version for Kubernetes"
# Changing into the Kubernetes source code directory is a workaround for https://github.com/kubernetes-sigs/kind/issues/1910
# shellcheck disable=SC2046
(cd "${CSI_PROW_WORK}/src/kubernetes" && run_with_go "$go_version" kind build node-image --image csiprow/node:latest --kube-root "${CSI_PROW_WORK}/src/kubernetes") || die "'kind build node-image' failed"
(cd "${CSI_PROW_WORK}/src/kubernetes" && run_with_go "$go_version" kind build node-image "${CSI_PROW_WORK}/src/kubernetes" --image csiprow/node:latest) || die "'kind build node-image' failed"
csi_prow_kind_have_kubernetes=true
fi
image="csiprow/node:latest"
Expand Down

0 comments on commit faf79ff

Please sign in to comment.