-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip resizing volume when extent is less than the minimum of 1MB. #271
Conversation
Migrate filesystem API Group to library model
Migrate disk API group to library model
Migrate volume API group to library model
Migrate system API group to library model
feat: migrate smb API group to library model
Migrate iscsi API group to library model
Remove v1 integration tests
Remove v1 client and pkg code
Document API group interface methods
…api-groups Rename Smb to SMB
Remove compatibility methods for old API versions
Document structs used in API group interfaces
…api-groups Rename iscsi to iSCSI
…api-groups Rename iqn to IQN
@cphvmware: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cphvmware The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @cphvmware! |
Hi @cphvmware. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fixes merge issue from PR #196 |
We're going to make some changes in the branches, after I move the current development to a different branch and v1.x back to master then I think I can enable the tests for this PR |
Yes, I noticed that I can't build csi-proxy right now. |
/ok-to-test |
@cphvmware we moved some branch around and now:
I think you might need to cherrypick your commit on top of the new tip of master, sorry about that! |
@cphvmware: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is skipping resize of the volume when extent is less than the minimum of 1MB
Which issue(s) this PR fixes:
Fixes #195
Special notes for your reviewer:
Validated changes with vSphere CSI Driver. Volume is getting expanded when the volume is resized before creating a filesystem on it.
Does this PR introduce a user-facing change?: