Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check partition error on MBR disk #175

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix: check partition error on MBR disk #175

merged 1 commit into from
Sep 29, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Sep 29, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: check partition error on MBR disk
Before k8s 1.22, all default windows disk type is MBR, and Type of Get-Partition for MBR disk is IFS, PR(#145) brings the breaking change, it would lead to check partition error on MBR disk, this PR only filters Basic type which could solve the issue.

Which issue(s) this PR fixes:

Fixes Azure/AKS#2568

Special notes for your reviewer:
/assign @wongma7 @jingxu97

partition type could also be Logic for MBR disk by running command:

Get-Disk| Where partitionstyle -eq 'raw'
Initialize-Disk -Number 16 -PartitionStyle MBR
New-Partition -DiskNumber 16 -UseMaximumSize
Get-Partition | Where DiskNumber -eq 16

Does this PR introduce a user-facing change?:

fix: check partition error on MBR disk

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: GitHub didn't allow me to assign the following users: wongma7.

Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: check partition error on MBR disk
Before k8s 1.22, all default windows disk type is MBR, and Type of Get-Partition for MBR disk is IFS, PR(#145) brings the breaking change, it would lead to check partition error on MBR disk

Which issue(s) this PR fixes:

Fixes Azure/AKS#2568

Special notes for your reviewer:
/assign @wongma7 @jingxu97

Does this PR introduce a user-facing change?:

fix: check partition error on MBR disk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2021
@wongma7
Copy link
Contributor

wongma7 commented Sep 29, 2021

/lgtm

my b, csi-proxy 1.0.0 will always format GPT so searching for Basic versus* excluding reserved is compatible with itself, but that is not backwards compatible with previous MBR volumes

@k8s-ci-robot
Copy link
Contributor

@wongma7: changing LGTM is restricted to collaborators

In response to this:

/lgtm

my b, csi-proxy 1.0.0 will always format GPT so excluding reserved is compatible with itself, but that is not backwards compatible with previous MBR volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggriffiths
Copy link
Member

Looks like this will be backwards compatible with the previous partition check from before #145.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit ebdbe95 into master Sep 29, 2021
@mauriciopoppe mauriciopoppe deleted the mbr-disk-fix branch October 21, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
5 participants