-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check partition error on MBR disk #175
Conversation
@andyzhangx: GitHub didn't allow me to assign the following users: wongma7. Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm my b, csi-proxy 1.0.0 will always format GPT so searching for Basic versus* excluding reserved is compatible with itself, but that is not backwards compatible with previous MBR volumes |
@wongma7: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like this will be backwards compatible with the previous partition check from before #145. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: check partition error on MBR disk
Before k8s 1.22, all default windows disk type is MBR, and
Type
ofGet-Partition
for MBR disk isIFS
, PR(#145) brings the breaking change, it would lead to check partition error on MBR disk, this PR only filtersBasic
type which could solve the issue.Which issue(s) this PR fixes:
Fixes Azure/AKS#2568
Special notes for your reviewer:
/assign @wongma7 @jingxu97
partition type could also be
Logic
for MBR disk by running command:Does this PR introduce a user-facing change?: