Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume and csi-proxy-api-gen E2E tests are skipped in github actions #139

Closed
mauriciopoppe opened this issue May 20, 2021 · 2 comments
Closed

Comments

@mauriciopoppe
Copy link
Member

mauriciopoppe commented May 20, 2021

What happened:
Some E2E tests are skipped if the test detects that it's running inside a Github Action workflow

What you expected to happen:
E2E tests shouldn't be skipped, it makes it hard to iterate if you don't know what you broke

How to reproduce it:
Comment the line

skipTestOnCondition(t, isRunningOnGhActions())

and send a PR that triggers the presubmit job, there's a powershell command that fails because Hyper-V is disabled.

See https://github.com/kubernetes-csi/csi-proxy/runs/2605742614?check_suite_focus=true for an example

Anything else we need to know?:
There are some commands that can't run in the Github Actions VM because it has hyper-V disabled, this feature was disabled in actions/runner-images#2525 and it looks like it's not coming back.

pohly added a commit to pohly/csi-proxy that referenced this issue May 21, 2021
a1e1127 Merge pull request kubernetes-csi#139 from pohly/kind-for-kubernetes-latest
1c0fb09 prow.sh: use KinD main for latest Kubernetes
1d77cfc Merge pull request kubernetes-csi#138 from pohly/kind-update-0.10
bff2fb7 prow.sh: KinD 0.10.0

git-subtree-dir: release-tools
git-subtree-split: a1e11275b5a4febd6ad21beeac730e22c579825b
@mauriciopoppe
Copy link
Member Author

The generator test isn't working at all, the generator can execute correctly but the test to take diffs between the actual and the desired generated states isn't correct, also the generator desired files are out of date.

@mauriciopoppe
Copy link
Member Author

We decided that it's ok to run the E2E tests manually for now, also because the generator is out of date we are no longer running this test either. (ref #138)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant