You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Anything else we need to know?:
There are some commands that can't run in the Github Actions VM because it has hyper-V disabled, this feature was disabled in actions/runner-images#2525 and it looks like it's not coming back.
The text was updated successfully, but these errors were encountered:
pohly
added a commit
to pohly/csi-proxy
that referenced
this issue
May 21, 2021
The generator test isn't working at all, the generator can execute correctly but the test to take diffs between the actual and the desired generated states isn't correct, also the generator desired files are out of date.
We decided that it's ok to run the E2E tests manually for now, also because the generator is out of date we are no longer running this test either. (ref #138)
What happened:
Some E2E tests are skipped if the test detects that it's running inside a Github Action workflow
csi-proxy/integrationtests/volume_test.go
Line 373 in c249530
csi-proxy/integrationtests/csi_api_gen_test.go
Line 21 in c249530
What you expected to happen:
E2E tests shouldn't be skipped, it makes it hard to iterate if you don't know what you broke
How to reproduce it:
Comment the line
csi-proxy/integrationtests/volume_test.go
Line 373 in c249530
and send a PR that triggers the presubmit job, there's a powershell command that fails because Hyper-V is disabled.
See https://github.com/kubernetes-csi/csi-proxy/runs/2605742614?check_suite_focus=true for an example
Anything else we need to know?:
There are some commands that can't run in the Github Actions VM because it has hyper-V disabled, this feature was disabled in actions/runner-images#2525 and it looks like it's not coming back.
The text was updated successfully, but these errors were encountered: