Updates in the Disk v1beta3 API

[mauriciopoppe]

API Changes:

• Change all parameters from camelCase to underscores e.g. diskNumber -> disk_number
• Use disk_number instead of ID, also change from string to int64
• PartitionDisk: is disk partitioned formatted? (TODO: ask michelle or deep about this one)
• ListDiskLocation TODO(mauricio): look for a better way to represent DiskLocation fields, it’s a map of Location to string but an empty location should be a nil pointer, check how this should be done in protobuf
• ListDIskIDsResponse, change diskIDs to disk_ids
• DiskIDs: change identifiers to map<DiskType, string>, DiskType is a new enum with only one value (page83), instead change it to a message with these known types: page83 and serial_number
• PartitionDisk add comment how is partitioned: “PartitionDisk initializes and partitions a disk device with the GPT partition style (if the disk has not been partitioned already) and returns the resulting volume device ID“
• Rescan: (typically part of nodeStageVolume, maybe move it to sytem API)? this is just a suggestion
• Change DiskStats to GetDiskStat, also change diskSize to total_bytes
• Change SetAttachState to SetDiskState also change request and response
• Change GetAttachState to GetDiskState, also change request and response
• Make sure that the comments match what the api does (all methods)

Also:

• change client API folder from v1 to v1beta3, check the setup in https://docs.google.com/document/d/1sBP8f_mwV0N_xRRQQGDwHZpU_nTHtpFxdi7LKSUtgX0/edit# and Generate v1 files from latest beta versions #120 for more details

[mauriciopoppe]

/assign