update to k/k 1.16

[jichenjc]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
solving kubernetes/cloud-provider-openstack#702 as I have to include leaderelection file into cloud provider openstack and when running dep ensure I have following error, seems csi-lib-utils still rely on k/k1.14 while conflict to cloud provider openstack on 1.16

Solving failure: No versions of github.com/kubernetes-csi/csi-lib-utils met constraints:
v0.6.1: Could not introduce github.com/kubernetes-csi/csi-lib-utils (from https://github.com/kubernetes-csi/csi-lib-utils)@v0.6.1, as it has a dependency on k8s.io/client-go with constraint kubernetes-1.14.0, which has no overlap with existing constraint kubernetes-1.16.0 from (root)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Welcome @jichenjc!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jichenjc
To complete the pull request process, please assign jsafrane
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pohly]

/assign @andrewsykim

Can you have a look at this? I don't know what the implications will be for other users of this lib if we bump the Kubernetes dependency to 1.16.

The underlying problem is that Kubernetes packages don't have semantic versioning. So even though csi-lib-utils seems to be compatible with any version >= 1.14 (or at least no code changes were necessary to compile with 1.16), we can't specify that in the Gopkg.toml file.

I don't know for sure how Go modules would handle this. I suspect it would allow us to select 1.14 for reproducible builds of csi-lib-utils, but as this isn't a minimal viable version with semantic versioning, users might accidentally pick something older.

[pohly]

Perhaps we can approximate the go mod behavior by removing the constraints from Gopkg.toml?

[jichenjc]

can we create a new tag e.g 0.6.2 if we bump to k/k 1.16 so older still can rely on 0.6.1? and for newer can rely on 0.6.2

the go mod might be another way to try as well

[andrewsykim]

@jichenjc would an override in your Gopkg.toml file for the kubernetes dependencies work?

[pohly]

@jichenjc: can you try whether the switch to go modules (#33) works for you?

[jichenjc]

ok, will try it later on (holiday approaching), thanks~

[pohly]

PR #33 was merged, please let us know whether this is still needed.

[jichenjc]

let me close this and let me try with go module first, if needed, might open another one. thanks~