Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade csi-provisioner to v5.0.2 on v1.15.0 chart #829

Merged

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 28, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: upgrade to csi-provisioner v5.0.2 on v1.15.0 chart

This PR upgrades csi-provisioner to v5.0.2 to avoid DeleteVolume twice

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: upgrade to csi-provisioner v5.0.2  on v1.15.0 chart

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2024
@andyzhangx andyzhangx changed the title fix: upgrade csi-provisioner to v5.0.2 fix: upgrade csi-provisioner to v5.0.2 on v1.15.0 chart Aug 28, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10595869503

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 78.912%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/controllerserver.go 0 6 0.0%
Totals Coverage Status
Change from base Build 10438420668: -0.2%
Covered Lines: 943
Relevant Lines: 1195

💛 - Coveralls

@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-smb-e2e-windows-2019 243f36f link false /test pull-csi-driver-smb-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 4d10e97 into kubernetes-csi:master Aug 29, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants