make image.*.repository variables relative by default

[amarkevich]

What type of PR is this?

/kind feature

What this PR does / why we need it:

image.baseRepo can be used to specify the registry once

Which issue(s) this PR fixes:

none

Requirements:

• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: amarkevich / name: Alexey Markevich (d581d0a)

[k8s-ci-robot]

Welcome @amarkevich!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @amarkevich. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coveralls]

Pull Request Test Coverage Report for Build 9793750705

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 79.093%

---

Totals
Change from base Build 9630570222:	0.0%
Covered Lines:	942
Relevant Lines:	1191

---

💛 - Coveralls

[andyzhangx]

/ok-to-test

[andyzhangx]

what's the point of this PR? baseRepo setting is already supported by following logic, you only need to make the doc more clear.

csi-driver-smb/charts/latest/csi-driver-smb/templates/csi-smb-controller.yaml

Lines 56 to 60 in 999ac2b

	{{- if hasPrefix "/" .Values.image.csiProvisioner.repository }}
	image: "{{ .Values.image.baseRepo }}{{ .Values.image.csiProvisioner.repository }}:{{ .Values.image.csiProvisioner.tag }}"
	{{- else }}
	image: "{{ .Values.image.csiProvisioner.repository }}:{{ .Values.image.csiProvisioner.tag }}"
	{{- end }}

[amarkevich]

To use 'baseRepo' all the 'image.*.repository' values should be relative.
This PR change default values to be relative and configured using 'baseRepo' by default

[andyzhangx]

To use 'baseRepo' all the 'image.*.repository' values should be relative. This PR change default values to be relative and configured using 'baseRepo' by default

@amarkevich this is already supported today

[amarkevich]

@andyzhangx now its not enough to set 'baseRepo' to switch image repository completely but all 'image.*.repository' values should be changed to be relative. This PR make it by default

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amarkevich, andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Pull Request Test Coverage Report for Build 9986357539

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 79.093%

---

Totals
Change from base Build 9983800682:	0.0%
Covered Lines:	942
Relevant Lines:	1191

---

💛 - Coveralls