Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: support windows host-process deployment #702

Closed
wants to merge 11 commits into from
Closed

[WIP] feat: support windows host-process deployment #702

wants to merge 11 commits into from

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Dec 5, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support windows host-process deployment

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: support windows host-process deployment

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 5, 2023
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2019

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz
/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

1 similar comment
@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz
/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz
/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz
/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2019

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2019
/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2024
@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess
/test pull-csi-driver-smb-e2e-capz-windows-2019

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9042206555

Details

  • 3 of 160 (1.88%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.1%) to 69.955%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/fake_mounter.go 0 1 0.0%
pkg/csi-common/utils.go 0 10 0.0%
pkg/os/smb/smb.go 0 32 0.0%
pkg/os/filesystem/filesystem.go 0 114 0.0%
Totals Coverage Status
Change from base Build 9032641981: -9.1%
Covered Lines: 943
Relevant Lines: 1348
💛 - Coveralls

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-smb-sanity bc96337 link true /test pull-csi-driver-smb-sanity
pull-csi-driver-smb-e2e-capz-windows-2019 bc96337 link false /test pull-csi-driver-smb-e2e-capz-windows-2019
pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess bc96337 link false /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @k8s-ci-robot @k8s-triage-robot @coveralls