-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] reference counting of used volumes on Windows nodes #676
[fix] reference counting of used volumes on Windows nodes #676
Conversation
Hi @vitaliy-leschenko. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Pull Request Test Coverage Report for Build 6560259839
💛 - Coveralls |
btw, other test failures would be fixed by #677 |
5432f81
to
8f1b7cc
Compare
717be1b
to
d754461
Compare
FAIL: TestIncementVolumeIDReferencesCount (0.00s) |
fixed |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, vitaliy-leschenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andyzhangx When can we expect a new release? |
@vitaliy-leschenko early Nov, is that ok? |
Ok. Thank you. |
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
The driver calls Remove-SmbGlobalMapping when it still required for other volumes.
How to reproduce the issue:
Release note: