Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] reference counting of used volumes on Windows nodes #676

Merged

Conversation

vitaliy-leschenko
Copy link
Contributor

What type of PR is this?
/kind bug

Which issue(s) this PR fixes:
The driver calls Remove-SmbGlobalMapping when it still required for other volumes.

How to reproduce the issue:

  1. create persistent volume A without storageClass for \fileserver\fileshare
  2. create persistent volume B without storageClass for the same path (\fileserver\fileshare)
  3. create pv claims AC and BC
  4. create pods AP with mounted pvc AC and pod BP with mounted BC
  5. remove only pod AP
  6. the drivers calls Remove-SmbGlobalMapping for \fileserver\fileshare <== bug

Release note:

[fix] reference counting of used volumes on Windows nodes

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @vitaliy-leschenko. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 18, 2023
@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6560259839

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.018%

Totals Coverage Status
Change from base Build 6081536992: 0.0%
Covered Lines: 901
Relevant Lines: 1126

💛 - Coveralls

@andyzhangx
Copy link
Member

btw, other test failures would be fixed by #677

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@andyzhangx
Copy link
Member

FAIL: TestIncementVolumeIDReferencesCount (0.00s)

@vitaliy-leschenko
Copy link
Contributor Author

FAIL: TestIncementVolumeIDReferencesCount (0.00s)

fixed

@andyzhangx
Copy link
Member

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, vitaliy-leschenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 08a0c5b into kubernetes-csi:master Oct 19, 2023
11 checks passed
@vitaliy-leschenko
Copy link
Contributor Author

@andyzhangx When can we expect a new release?

@andyzhangx
Copy link
Member

@andyzhangx When can we expect a new release?

@vitaliy-leschenko early Nov, is that ok?

@vitaliy-leschenko
Copy link
Contributor Author

vitaliy-leschenko commented Oct 19, 2023

@vitaliy-leschenko early Nov, is that ok?

Ok. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants