Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: driver pod crash issue on Windows #359

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Sep 30, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
Sets the initialDelaySeconds and timeoutSeconds for the node-driver-registrar livenessprobe check.

  • The default timeoutSeconds of 1s is honored starting from Kubernetes 1.20 and is aggressive. Setting the value to 15s which is appropriate for linux and windows.
  • Setting initialDelaySeconds to 30s to provide time for the socket to be created and driver to be registered during startup of the driver pods.

Ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes for defaults

similar to fix: kubernetes-sigs/secrets-store-csi-driver#729

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: driver pod crash issue on Windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1289495766

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.3%

Totals Coverage Status
Change from base Build 1289484462: 0.0%
Covered Lines: 800
Relevant Lines: 927

💛 - Coveralls

@lizhuqi
Copy link
Contributor

lizhuqi commented Oct 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2021
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d298cb8 into kubernetes-csi:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants