Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove windows image config in chart #339

Merged
merged 3 commits into from
Aug 27, 2021
Merged

cleanup: remove windows image config in chart #339

merged 3 commits into from
Aug 27, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
cleanup: remove windows image config in chart

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

cleanup: remove windows image config in chart

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2021
@coveralls
Copy link

coveralls commented Aug 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1173480015

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.241%
Totals Coverage Status
Change from base Build 1172758073: 0.0%
Covered Lines: 796
Relevant Lines: 923
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

k8s.gcr.io/sig-storage/livenessprobe:v2.3.0 image does not support containerd, switch to mcr image:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-smb/339/pull-csi-driver-smb-e2e-windows-containerd/1431103976555679744/build-log.txt

print out csi-smb-node-win events ...
======================================================================================
Name:                 csi-smb-node-win-lf9ms
Namespace:            kube-system
Priority:             2000001000
Priority Class Name:  system-node-critical
Node:                 1219k8s001/10.240.0.4
Start Time:           Fri, 27 Aug 2021 04:13:33 +0000
Labels:               app=csi-smb-node-win
                      app.kubernetes.io/instance=csi-driver-smb
                      app.kubernetes.io/managed-by=Helm
                      app.kubernetes.io/name=csi-driver-smb
                      app.kubernetes.io/version=latest
                      controller-revision-hash=576d6cdbb5
                      helm.sh/chart=csi-driver-smb-v1.3.0
                      pod-template-generation=1
Annotations:          kubernetes.io/psp: privileged
Status:               Pending
IP:                   10.240.0.7
IPs:
  IP:           10.240.0.7
Controlled By:  DaemonSet/csi-smb-node-win
Containers:
  liveness-probe:
    Container ID:  
    Image:         k8s.gcr.io/sig-storage/livenessprobe:v2.3.0
    Image ID:      
    Port:          <none>
    Host Port:     <none>
    Args:
      --csi-address=$(CSI_ENDPOINT)
      --probe-timeout=3s
      --health-port=29643
      --v=2
    State:          Waiting
      Reason:       ImagePullBackOff
    Ready:          False
    Restart Count:  0
    Limits:
      cpu:     200m
      memory:  200Mi
    Requests:
      cpu:     10m
      memory:  20Mi
    Environment:
      CSI_ENDPOINT:  unix://C:\\csi\\csi.sock
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-d9p77 (ro)
      C:\csi from plugin-dir (rw)
  node-driver-registrar:
    Container ID:  containerd://bd2c01e1ee4bbe7ed7e1974ef9d275d5828e8cc5efcb9d0d1a39035ec1cf8836
    Image:         k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0
    Image ID:      k8s.gcr.io/sig-storage/csi-node-driver-registrar@sha256:f9bcee63734b7b01555ee8fc8fb01ac2922478b2c8934bf8d468dd2916edc405
    Port:          <none>
    Host Port:     <none>
    Args:
      --v=2
      --csi-address=$(CSI_ENDPOINT)
      --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
    State:          Running
      Started:      Fri, 27 Aug 2021 04:14:00 +0000
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     200m
      memory:  200Mi
    Requests:
      cpu:     10m
      memory:  20Mi
    Liveness:  exec [/csi-node-driver-registrar.exe --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH) --mode=kubelet-registration-probe] delay=3s timeout=1s period=10s #success=1 #failure=3
    Environment:
      CSI_ENDPOINT:          unix://C:\\csi\\csi.sock
      DRIVER_REG_SOCK_PATH:  C:\var\lib\kubelet\\plugins\\smb.csi.k8s.io\\csi.sock
      KUBE_NODE_NAME:         (v1:spec.nodeName)
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-d9p77 (ro)
      C:\csi from plugin-dir (rw)
      C:\registration from registration-dir (rw)
  smb:
    Container ID:  containerd://99469be34dfcbbefa3aee115e7bc4836f0f0500c929e0dc67cac062461d00624
    Image:         k8sprow.azurecr.io/smb-csi:e2e-9b665b5ef673e51e7865ab180ee558aae9106247
    Image ID:      k8sprow.azurecr.io/smb-csi@sha256:5748e70a792d38c967a3ed3e3d9a03917db0aae04f74ae340ea251fff0022746
    Port:          29643/TCP
    Host Port:     0/TCP
    Args:
      --v=6
      --drivername=smb.csi.k8s.io
      --endpoint=$(CSI_ENDPOINT)
      --nodeid=$(KUBE_NODE_NAME)
      --metrics-address=0.0.0.0:29645
    State:          Running
      Started:      Fri, 27 Aug 2021 04:25:59 +0000
    Last State:     Terminated
      Reason:       Error
      Exit Code:    -1073741510
      Started:      Fri, 27 Aug 2021 04:22:59 +0000
      Finished:     Fri, 27 Aug 2021 04:25:57 +0000
    Ready:          True
    Restart Count:  4
    Limits:
      cpu:     400m
      memory:  400Mi
    Requests:
      cpu:     10m
      memory:  20Mi
    Liveness:  http-get http://:healthz/healthz delay=30s timeout=10s period=30s #success=1 #failure=5
    Environment:
      CSI_ENDPOINT:    unix://C:\\csi\\csi.sock
      KUBE_NODE_NAME:   (v1:spec.nodeName)
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-d9p77 (ro)
      C:\csi from plugin-dir (rw)
      C:\var\lib\kubelet\ from kubelet-dir (rw)
      \\.\pipe\csi-proxy-filesystem-v1 from csi-proxy-fs-pipe-v1 (rw)
      \\.\pipe\csi-proxy-filesystem-v1beta1 from csi-proxy-fs-pipe-v1beta1 (rw)
      \\.\pipe\csi-proxy-smb-v1 from csi-proxy-smb-pipe-v1 (rw)
      \\.\pipe\csi-proxy-smb-v1beta1 from csi-proxy-smb-pipe-v1beta1 (rw)
Conditions:
  Type              Status
  Initialized       True 
  Ready             False 
  ContainersReady   False 
  PodScheduled      True 
Volumes:
  csi-proxy-fs-pipe-v1:
    Type:          HostPath (bare host directory volume)
    Path:          \\.\pipe\csi-proxy-filesystem-v1
    HostPathType:  
  csi-proxy-smb-pipe-v1:
    Type:          HostPath (bare host directory volume)
    Path:          \\.\pipe\csi-proxy-smb-v1
    HostPathType:  
  csi-proxy-fs-pipe-v1beta1:
    Type:          HostPath (bare host directory volume)
    Path:          \\.\pipe\csi-proxy-filesystem-v1beta1
    HostPathType:  
  csi-proxy-smb-pipe-v1beta1:
    Type:          HostPath (bare host directory volume)
    Path:          \\.\pipe\csi-proxy-smb-v1beta1
    HostPathType:  
  registration-dir:
    Type:          HostPath (bare host directory volume)
    Path:          C:\var\lib\kubelet\plugins_registry\
    HostPathType:  Directory
  kubelet-dir:
    Type:          HostPath (bare host directory volume)
    Path:          C:\var\lib\kubelet\
    HostPathType:  Directory
  plugin-dir:
    Type:          HostPath (bare host directory volume)
    Path:          C:\var\lib\kubelet\plugins\smb.csi.k8s.io\
    HostPathType:  DirectoryOrCreate
  default-token-d9p77:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-d9p77
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  kubernetes.io/os=windows
Tolerations:     node.kubernetes.io/disk-pressure:NoSchedule op=Exists
                 node.kubernetes.io/memory-pressure:NoSchedule op=Exists
                 node.kubernetes.io/not-ready:NoExecute op=Exists
                 node.kubernetes.io/os:NoSchedule op=Exists
                 node.kubernetes.io/pid-pressure:NoSchedule op=Exists
                 node.kubernetes.io/unreachable:NoExecute op=Exists
                 node.kubernetes.io/unschedulable:NoSchedule op=Exists
Events:
  Type     Reason     Age                   From               Message
  ----     ------     ----                  ----               -------
  Normal   Scheduled  15m                   default-scheduler  Successfully assigned kube-system/csi-smb-node-win-lf9ms to 1219k8s001
  Normal   Pulling    14m                   kubelet            Pulling image "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
  Normal   Pulled     14m                   kubelet            Successfully pulled image "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0"
  Normal   Created    14m                   kubelet            Created container node-driver-registrar
  Normal   Pulling    14m                   kubelet            Pulling image "k8sprow.azurecr.io/smb-csi:e2e-9b665b5ef673e51e7865ab180ee558aae9106247"
  Normal   Started    14m                   kubelet            Started container node-driver-registrar
  Normal   Pulled     14m                   kubelet            Successfully pulled image "k8sprow.azurecr.io/smb-csi:e2e-9b665b5ef673e51e7865ab180ee558aae9106247"
  Normal   Created    14m                   kubelet            Created container smb
  Normal   Started    14m                   kubelet            Started container smb
  Normal   Pulling    14m (x3 over 14m)     kubelet            Pulling image "k8s.gcr.io/sig-storage/livenessprobe:v2.3.0"
  Warning  Failed     14m (x3 over 14m)     kubelet            Error: ErrImagePull
  Normal   BackOff    4m57s (x48 over 14m)  kubelet            Back-off pulling image "k8s.gcr.io/sig-storage/livenessprobe:v2.3.0"

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2021
@andyzhangx andyzhangx merged commit 15c72c6 into kubernetes-csi:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls