Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to csi-proxy-v1.0.1 #333

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
chore: upgrade to csi-proxy-v1.0.1

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1069608210

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.241%

Totals Coverage Status
Change from base Build 1069603951: 0.0%
Covered Lines: 796
Relevant Lines: 923

💛 - Coveralls

@lizhuqi
Copy link
Contributor

lizhuqi commented Jul 27, 2021

/test pull-csi-driver-smb-e2e-gce

@lizhuqi
Copy link
Contributor

lizhuqi commented Jul 27, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@lizhuqi: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

@lizhuqi would you fix the pull-csi-driver-smb-e2e-gce failure? this PR should not be related to the test failure.

@lizhuqi
Copy link
Contributor

lizhuqi commented Jul 31, 2021

/test pull-csi-driver-smb-e2e-gce

@lizhuqi
Copy link
Contributor

lizhuqi commented Jul 31, 2021

Only one test case is failing in pull-csi-driver-smb-e2e-gce now. Rerun to see if it was transient.

/test pull-csi-driver-smb-e2e-gce

@lizhuqi
Copy link
Contributor

lizhuqi commented Aug 3, 2021

Return to see if the networking resources leaked is one-off
/test pull-csi-driver-smb-e2e-gce

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-csi-driver-smb-e2e-gce 9768330 link /test pull-csi-driver-smb-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lizhuqi
Copy link
Contributor

lizhuqi commented Aug 3, 2021

/lgtm

the leaking resource issue is caused by util failed to clean up firewalls.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit e7ad256 into kubernetes-csi:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants