Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve name to ip before passing to csi-proxy #309

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

lizhuqi
Copy link
Contributor

@lizhuqi lizhuqi commented Jun 15, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
csi-proxy is running in hostnetwork so it can't resolve hostname of k8s services to IP. This PR resolves name to ip before passing to csi-proxy.

Which issue(s) this PR fixes:
Fixes #294

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lizhuqi. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 15, 2021
@lizhuqi lizhuqi force-pushed the convert-name-to-ip branch from 5d1fcc2 to 13173e7 Compare June 15, 2021 23:52
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jun 15, 2021

/test pull-csi-driver-smb-e2e-gce

@k8s-ci-robot
Copy link
Contributor

@lizhuqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-csi-driver-smb-e2e-gce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jun 16, 2021

Pull Request Test Coverage Report for Build 941949941

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.241%

Totals Coverage Status
Change from base Build 937757284: 0.0%
Covered Lines: 796
Relevant Lines: 923

💛 - Coveralls

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
pkg/mounter/safe_mounter_windows.go Outdated Show resolved Hide resolved
pkg/mounter/safe_mounter_windows.go Show resolved Hide resolved
pkg/mounter/safe_mounter_windows.go Outdated Show resolved Hide resolved
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jun 16, 2021

/test pull-csi-driver-smb-e2e-gce

@lizhuqi lizhuqi force-pushed the convert-name-to-ip branch from 13173e7 to 19be772 Compare June 16, 2021 07:06
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 16, 2021

@lizhuqi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-csi-driver-smb-e2e-gce 13173e7 link /test pull-csi-driver-smb-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, lizhuqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit fc93307 into kubernetes-csi:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smb-server.default.svc.cluster.local could not be recognized by New-SmbGlobalMapping command on Windows node
4 participants