Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create subDir in CreateVolume and delete subDir in DeleteVolume #259

Merged
merged 1 commit into from
Jun 2, 2021
Merged

create subDir in CreateVolume and delete subDir in DeleteVolume #259

merged 1 commit into from
Jun 2, 2021

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented May 7, 2021 •
edited by andyzhangx
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #120

Requirements:

Special notes for your reviewer:

Release note:

create subDir in CreateVolume and delete subDir in DeleteVolume

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @boddumanohar. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2021
@boddumanohar boddumanohar changed the title create subDir in CreateVolume and delete in DeleteVolume create subDir in CreateVolume and delete subDir in DeleteVolume May 7, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch 6 times, most recently from 91e7ce6 to 18042f2 Compare May 7, 2021 19:05
@boddumanohar boddumanohar changed the title create subDir in CreateVolume and delete subDir in DeleteVolume [WIP] create subDir in CreateVolume and delete subDir in DeleteVolume May 7, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch 3 times, most recently from 1db8d65 to 7c43be6 Compare May 10, 2021 08:59
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch from 895dc15 to 0cceb27 Compare May 11, 2021 17:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch 5 times, most recently from cb622ae to b80ede9 Compare May 12, 2021 05:49
andyzhangx
andyzhangx reviewed May 12, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch from 689623b to c69757b Compare May 18, 2021 08:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch from 167ba47 to 9d66c14 Compare May 19, 2021 06:13
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 19, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch from 62c20c9 to 373c591 Compare May 19, 2021 11:07
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch from f9ce5ee to 074c1ec Compare May 19, 2021 11:55
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch from 074c1ec to d852410 Compare May 20, 2021 17:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2021
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch 3 times, most recently from ad0ee80 to 885eac9 Compare May 24, 2021 06:02
@andyzhangx andyzhangx mentioned this pull request Jun 1, 2021
Closed
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch 2 times, most recently from 760d0fe to 4016069 Compare June 1, 2021 14:42
@boddumanohar boddumanohar force-pushed the createvol-delete-vol-full-support branch from 6316261 to d020b78 Compare June 1, 2021 16:43
@k8s-ci-robot
Copy link
Contributor

@boddumanohar: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-csi-driver-smb-e2e-gce d020b78 link /test pull-csi-driver-smb-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

andyzhangx
andyzhangx approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@andyzhangx andyzhangx merged commit f4b54f2 into kubernetes-csi:master Jun 2, 2021
@boddumanohar boddumanohar mentioned this pull request Jun 3, 2021
Closed
andyzhangx added a commit to andyzhangx/csi-driver-smb that referenced this pull request Dec 10, 2024
@andyzhangx
Squashed 'release-tools/' changes from 227577e00..98f23071d
2ae52b4 
98f23071d Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d0 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff66 Remove --kube-root deprecated kind argument
734c2b950 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855be Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966fe Treat main branch as equivalent to master branch
e31de525b Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e2 Bump golang to 1.23.1
a8b3d0504 pull-test.sh: fix "git subtree pull" errors
6b05f0fcc use new GOTOOLCHAIN env to manage go version
18b6ac6d2 chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dynamic provisioning fully support
4 participants
@boddumanohar @k8s-ci-robot @coveralls @andyzhangx