-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use controlplane instead of master #243
Conversation
@maxisam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maxisam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @maxisam! |
Hi @maxisam. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- should only change
latest
folder, and also change charts config - is it possible to add a new toleration
node-role.kubernetes.io/controlplane
, that would make this driver compatible with old k8s release, we should still supportnode-role.kubernetes.io/master
for a long time
@boddumanohar could you help with a new PR to address the above comments? thanks. |
fixed by #247, thanks! |
f8c8cc4c7 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bfdc Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc9a Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c4650889d pull-test.sh: avoid "git subtree pull" error 7b175a1e2 Update csi-test version to v5.2.0 987c90ccd Update go version to 1.21 to match k/k 2c625d41d Add script to generate patch release notes f9d5b9c05 Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd5372 Bump csi-driver-host-path version up to v1.12.0 984feece4 Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e60599 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: f8c8cc4c7414c11526f14649856ff8e6b8a4e67c
What type of PR is this?
/kind bug
/kind deprecation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #242