Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runOnMaster switch for helm chart #223

Merged
merged 1 commit into from
Feb 5, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add runOnMaster switch for helm chart
boddumanohar committed Feb 5, 2021
commit d2cf8896aa24b94ccba248ed7d3787e6f9f1ed0e
1 change: 1 addition & 0 deletions charts/README.md
Original file line number Diff line number Diff line change
@@ -59,6 +59,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv
| `windows.image.nodeDriverRegistrar.pullPolicy` | windows csi-node-driver-registrar image pull policy | IfNotPresent |
| `kubelet.linuxPath` | configure the kubelet path for Linux node | `/var/lib/kubelet` |
| `kubelet.windowsPath` | configure the kubelet path for Windows node | `'C:\var\lib\kubelet'` |
| `controller.runOnMaster` | run controller on master node | false |

## troubleshooting
- Add `--wait -v=5 --debug` in `helm install` command to get detailed error
Binary file modified charts/latest/csi-driver-smb-v0.7.0.tgz
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -18,6 +18,9 @@ spec:
serviceAccountName: csi-smb-controller-sa
nodeSelector:
kubernetes.io/os: linux
{{- if .Values.controller.runOnMaster}}
kubernetes.io/role: master
{{- end}}
priorityClassName: system-cluster-critical
tolerations:
- key: "node-role.kubernetes.io/master"
1 change: 1 addition & 0 deletions charts/latest/csi-driver-smb/values.yaml
Original file line number Diff line number Diff line change
@@ -25,6 +25,7 @@ rbac:
controller:
replicas: 2
metricsPort: 29644
runOnMaster: false

node:
metricsPort: 29645