Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] CSI SMB Volume Expansion #347

Closed
san360 opened this issue Sep 13, 2021 · 14 comments
Closed

[feature request] CSI SMB Volume Expansion #347

san360 opened this issue Sep 13, 2021 · 14 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@san360
Copy link

san360 commented Sep 13, 2021

Tried to expand allocated PVC by editing capacity:

Update the PVC and underlying PV:

Create a PVC via YAML and redeploy the PVC after updating the capacity:

Environment:

  • CSI Driver version: 1.20
  • Kubernetes version (use kubectl version): 1.20
  • OS (e.g. from /etc/os-release): Linux, Ubuntu
@andyzhangx
Copy link
Member

it's not supported yet, implement a dummy volume expansion may solve this issue. This SMB driver actually does not manage volume capacity actually, does a dummy volume expansion work for you?

@andyzhangx andyzhangx changed the title CSI SMB Volume Expansion [feature request] CSI SMB Volume Expansion Sep 28, 2021
@gavin-ellis
Copy link

What steps can be taken to expand the volume?
Is the spec.storage.capacity value not enforced?
Does increasing the capacity in the PVC work?

@andyzhangx
Copy link
Member

What steps can be taken to expand the volume? Is the spec.storage.capacity value not enforced? Does increasing the capacity in the PVC work?

@gavin-ellis it's not supported

@winromulus
Copy link

@andyzhangx what do you mean by a dummy expansion and how would that be achieved?

@andyzhangx
Copy link
Member

@andyzhangx what do you mean by a dummy expansion and how would that be achieved?

@andyzhangx this driver could not expand the real volume size, if you input a larger volume size, this driver would just return success, that's called dummy expansion, not sure whether it's reasonable for such behavior.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx andyzhangx reopened this Jun 9, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joymon
Copy link

joymon commented Feb 23, 2023

Does this mean if I give 100 Gi capacity in PV and 10Gi PVC storage, I can store more than that if the underlying SMB server has storage?
Below is the way we are giving the storage size.
storage: 100Gi

Is this setting required to use the driver or just leave it empty to have all the storage on SMB server be used?

@andyzhangx
Copy link
Member

Does this mean if I give 100 Gi capacity in PV and 10Gi PVC storage, I can store more than that if the underlying SMB server has storage? Below is the way we are giving the storage size. storage: 100Gi

Is this setting required to use the driver or just leave it empty to have all the storage on SMB server be used?

@joymon the pvc capacity does not enforce the actual data size, it's only for pv/pvc matching.

@andyzhangx andyzhangx reopened this Nov 25, 2024
@andyzhangx
Copy link
Member

fixed by #881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants