test: fix windows test failure

kubernetes-csi · Jul 18, 2024 · c3e36cc · c3e36cc
1 parent 308d326
commit c3e36cc
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/pkg/smb/controllerserver_test.go b/pkg/smb/controllerserver_test.go
@@ -849,19 +849,20 @@ func TestCopyFromVolume(t *testing.T) {
 	}
 
 	for _, test := range cases {
-		test := test //pin
-		t.Run(test.desc, func(t *testing.T) {
-			// Setup
-			_ = os.MkdirAll(filepath.Join(d.workingMountDir, testCSIVolume, testCSIVolume), os.ModePerm)
+		if test.desc == "valid copy" && runtime.GOOS == "windows" {
+			t.Skip("Skipping test on Windows")
+		}
 
-			err := d.copyFromVolume(context.TODO(), test.req, test.dstVol)
-			if runtime.GOOS == "windows" {
-				fmt.Println("Skipping checks on Windows ENV") // nolint
-			} else {
-				if !reflect.DeepEqual(err, test.expectErr) {
-					t.Errorf("[test: %s] Unexpected error: %v, expected error: %v", test.desc, err, test.expectErr)
-				}
+		// Setup
+		_ = os.MkdirAll(filepath.Join(d.workingMountDir, testCSIVolume, testCSIVolume), os.ModePerm)
+
+		err := d.copyFromVolume(context.TODO(), test.req, test.dstVol)
+		if runtime.GOOS == "windows" {
+			fmt.Println("Skipping checks on Windows ENV") // nolint
+		} else {
+			if !reflect.DeepEqual(err, test.expectErr) {
+				t.Errorf("[test: %s] Unexpected error: %v, expected error: %v", test.desc, err, test.expectErr)
 			}
-		})
+		}
 	}
 }