Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: copy volume from volume unit tests #433

Merged
merged 1 commit into from
Mar 22, 2023
Merged

test: copy volume from volume unit tests #433

merged 1 commit into from
Mar 22, 2023

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Mar 21, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
increase unit test coverage to 77.08% (after a decrease 77.33% -> 73.27% in #426 (comment)), covering:

  • happy case
  • source volume arg mismatch
  • destination volume arg mismatch

Which issue(s) this PR fixes:

followup to #426

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2023
@wozniakjan wozniakjan force-pushed the test_copy_vol_unit_tests branch from 705819f to 1507f51 Compare March 21, 2023 16:46
@coveralls
Copy link

coveralls commented Mar 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4481643598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.8%) to 77.078%
Totals Coverage Status
Change from base Build 4453150478: 3.8%
Covered Lines: 649
Relevant Lines: 842
💛 - Coveralls

andyzhangx
andyzhangx approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, wozniakjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6906f97 into kubernetes-csi:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@pohly pohly Awaiting requested review from pohly

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wozniakjan @coveralls @k8s-ci-robot @andyzhangx