-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parametrization of deployment strategy for csi controller #375
feat: parametrization of deployment strategy for csi controller #375
Conversation
|
Hi @mariouhrin. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 3060582475
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, mariouhrin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
It allows the options to override default deployment strategy for csi controller (from RollingUpdate to Recreate).
In my company, we are using single node k3s cluster. We had an issue with already allocated port after new deployments of csi-driver-nfs helm chart.
This is the error logs from csi controller pod:
Warning FailedScheduling 12m (x42 over 44m) default-scheduler 0/1 nodes are available: 1 node(s) didn't have free ports for the requested pod ports.
The problematic port was this one (csi controller deployment manifest):
The Recreate deployment strategy helped us to avoid this already allocated port issue. The RollingUpdate deployment strategy is probably causing a problem when the old and new pods are running at the same time and 29652 port cannot be used for new pod. But maybe I am wrong.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: