-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add subPath e2e test #181
add subPath e2e test #181
Conversation
Hi @boddumanohar. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
0370392
to
688b747
Compare
688b747
to
3a9b724
Compare
Pull Request Test Coverage Report for Build 726101432
💛 - Coveralls |
@andyzhangx instead of writing custom tests, can we reuse the kubernetes e2e testsuites? You get 50+ test cases for free. https://github.com/kubernetes/kubernetes/tree/fa558043c02cae10ffbe001b46a7166231d07f60/test/e2e/storage/external |
thanks for reminder, since this case is already done, let's merge it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, boddumanohar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support to build arm/v7 images
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
add subPath e2e test
Which issue(s) this PR fixes:
Fixes #162
Special notes for your reviewer:
Does this PR introduce a user-facing change?: