Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add liveness probe healthz port #175

Merged
merged 1 commit into from
Mar 13, 2021
Merged

feat: add liveness probe healthz port #175

merged 1 commit into from
Mar 13, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Mar 13, 2021 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add liveness probe healthz port
also port fix from kubernetes-sigs/blob-csi-driver#362

Which issue(s) this PR fixes:

Fixes #173

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: add liveness probe healthz port

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali March 13, 2021 12:17
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 649013206

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.47%
Totals Coverage Status
Change from base Build 642973995: 0.0%
Covered Lines: 548
Relevant Lines: 681
💛 - Coveralls

@andyzhangx andyzhangx mentioned this pull request Mar 13, 2021
Closed
@andyzhangx andyzhangx merged commit 7e54331 into kubernetes-csi:master Mar 13, 2021
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#175 from jimdaga/patch-1
5b9a1e0 
images: use k8s-staging-test-infra/gcb-docker-gcloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csi-nfs-controller on the same node, gives a CrashLoopBackOff
3 participants
@andyzhangx @k8s-ci-robot @coveralls