Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change base image to debian #164

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
chore: change base image to debian

same as https://github.com/kubernetes-csi/csi-driver-smb/blob/a6fcf70cf8bf8ca1673147bcc9b7f7ceef29386f/pkg/smbplugin/Dockerfile#L18

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
original base image error:

nfs image building error:
#3 [internal] load metadata for docker.io/library/centos:latest
#3 ERROR: no match for platform in manifest sha256:5528e8b1b1719d34604c87e11dcd1c0a20bedf46e83b5632cdeac91b8c04efc1: not found

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-csi-driver-nfs-push-images/1362034346201976832

Does this PR introduce a user-facing change?:

chore: change base image to debian

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2021
@andyzhangx andyzhangx changed the title chore: change base image to debian fix: change base image to debian Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2021
@coveralls
Copy link

coveralls commented Feb 20, 2021

Pull Request Test Coverage Report for Build 584361993

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.47%

Totals Coverage Status
Change from base Build 583217558: 0.0%
Covered Lines: 548
Relevant Lines: 681

💛 - Coveralls

@andyzhangx andyzhangx merged commit ac023bf into kubernetes-csi:master Feb 21, 2021
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants