Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use klog instead of glog #137

Merged
merged 1 commit into from
Jan 20, 2021
Merged

chore: use klog instead of glog #137

merged 1 commit into from
Jan 20, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
chore: use klog instead of glog

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chore: use klog instead of glog

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2021
@coveralls
Copy link

coveralls commented Jan 19, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 496222571

  • 13 of 23 (56.52%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.615%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/controllerserver.go 4 6 66.67%
pkg/nfs/server.go 1 5 20.0%
pkg/nfs/utils.go 0 4 0.0%
Totals Coverage Status
Change from base Build 494933080: 0.0%
Covered Lines: 496
Relevant Lines: 623
💛 - Coveralls

@andyzhangx
chore: use klog instead of glog
4e11d43 
chore: use klog in nfs binary build

update go mod
@andyzhangx andyzhangx merged commit 3e9ef1e into kubernetes-csi:master Jan 20, 2021
pohly added a commit to pohly/csi-driver-nfs that referenced this pull request Mar 18, 2021
@pohly
Squashed 'release-tools/' changes from 1748b16..95eac33
73eb5ef 
95eac33 Merge pull request kubernetes-csi#137 from pohly/fix-go-version-check
437e431 verify-go-version.sh: fix check after removal of travis.yml

git-subtree-dir: release-tools
git-subtree-split: 95eac33
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#137 from pohly/fix-go-version-check
95eac33 
verify-go-version.sh: fix check after removal of travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls