Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2021-3997 in image build #87

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: CVE-2021-3997 in image build, fixed following image CVE:

https://github.com/kubernetes-csi/csi-driver-iscsi/runs/4810456604?check_suite_focus=true

test/iscsi-csi:latest (ubuntu 20.04)
====================================
Total: 2 (UNKNOWN: 0, LOW: 0, MEDIUM: 2, HIGH: 0, CRITICAL: 0)

+-------------+------------------+----------+-------------------+-------------------+--------------------------------------+
|   LIBRARY   | VULNERABILITY ID | SEVERITY | INSTALLED VERSION |   FIXED VERSION   |                TITLE                 |
+-------------+------------------+----------+-------------------+-------------------+--------------------------------------+
| libsystemd0 | CVE-2021-3997    | MEDIUM   | 245.4-4ubuntu3.14 | 245.4-4ubuntu3.15 | systemd: Uncontrolled recursion in   |
|             |                  |          |                   |                   | systemd-tmpfiles when removing files |
|             |                  |          |                   |                   | -->avd.aquasec.com/nvd/cve-2021-3997 |
+-------------+                  +          +                   +                   +                                      +
| libudev1    |                  |          |                   |                   |                                      |
|             |                  |          |                   |                   |                                      |
|             |                  |          |                   |                   |                                      |
+-------------+------------------+----------+-------------------+-------------------+--------------------------------------+

iscsiplugin (gobinary)
======================
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: CVE-2021-3997 in image build

@andyzhangx andyzhangx requested a review from humblec January 14, 2022 02:45
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2022
@andyzhangx
Copy link
Member Author

@humblec I realized we don't have an e2e test for this repo, is it possible to set up a containerized iscsi server and then add e2e tests, I could help set up the test pipeline if there is a solution.

@humblec
Copy link
Contributor

humblec commented Jan 14, 2022

@humblec I realized we don't have an e2e test for this repo, is it possible to set up a containerized iscsi server and then add e2e tests, I could help set up the test pipeline if there is a solution.

Yeah, have to experiment e2e. We will cut a alpha release and between alpha to GA we will bring up the e2e . . wdyt?

@humblec
Copy link
Contributor

humblec commented Jan 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8594fb8 into kubernetes-csi:master Jan 14, 2022
@andyzhangx
Copy link
Member Author

@humblec I realized we don't have an e2e test for this repo, is it possible to set up a containerized iscsi server and then add e2e tests, I could help set up the test pipeline if there is a solution.

Yeah, have to experiment e2e. We will cut a alpha release and between alpha to GA we will bring up the e2e . . wdyt?

@humblec lgtm, with an e2e test pipeline, I would be more confident when I make code change.

@humblec
Copy link
Contributor

humblec commented Jan 14, 2022

@humblec I realized we don't have an e2e test for this repo, is it possible to set up a containerized iscsi server and then add e2e tests, I could help set up the test pipeline if there is a solution.

Yeah, have to experiment e2e. We will cut a alpha release and between alpha to GA we will bring up the e2e . . wdyt?

@humblec lgtm, with an e2e test pipeline, I would be more confident when I make code change.

Agreed. !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants