-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CVE-2021-3997 in image build #87
fix: CVE-2021-3997 in image build #87
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@humblec I realized we don't have an e2e test for this repo, is it possible to set up a containerized iscsi server and then add e2e tests, I could help set up the test pipeline if there is a solution. |
fix tess
9d50b6c
to
98191a7
Compare
Yeah, have to experiment e2e. We will cut a alpha release and between alpha to GA we will bring up the e2e . . wdyt? |
/lgtm |
@humblec lgtm, with an e2e test pipeline, I would be more confident when I make code change. |
Agreed. ! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: CVE-2021-3997 in image build, fixed following image CVE:
https://github.com/kubernetes-csi/csi-driver-iscsi/runs/4810456604?check_suite_focus=true
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: