chore: remove csi-lib-iscsi vendor #253
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
size/L
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thanks @andyzhangx .. just to mention there are some direct consumers of that library, so archival of that should go some cadence.. regardless getting it as part of this driver is a good first step! |
@humblec do you have the repo link of those direct consumers of this library? |
https://github.com/Seagate is one of the big consumer of that library and making its way to their CSI driver. |
|
may be a couple of commits here can be squashed.. rest looks fine to me . thanks ! |
chore: add header test: fix golint
test: fix golint
andyzhangx
force-pushed
the
remove-iscsi-lib
branch
from
f141023 to
69b5ca7
Compare
|
It looks like https://github.com/Seagate forked the csi-lib-iscsi repo. |
|
Looks good to me. Please squash the commits. |
| - name: Set up Go 1.x | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: ^1.19 |
There was a problem hiding this comment.
@andyzhangx do we need to try on 1.20 at least?
There was a problem hiding this comment.
that's minimum golang requirement, it's actully using 1.21 now:
Successfully set up Go version ^1.19
/opt/hostedtoolcache/go/1.21.6/x64/bin/go env GOMODCACHE
/opt/hostedtoolcache/go/1.21.6/x64/bin/go env GOCACHE
/home/runner/go/pkg/mod
/home/runner/.cache/go-build
Warning: Restore cache failed: Dependencies file is not found in /home/runner/work/csi-driver-iscsi/csi-driver-iscsi. Supported file pattern: go.sum
go version go1.21.6 linux/amd64
|
minor comment otherwise it looks good to me.. |
@humblec I have squashed to 2 commits now, 1 for lib movement and another for golint change commit, could you approve? thanks. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, humblec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow dc4d0ae Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b17 Use .go-version to get Kubernetes go version 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules git-subtree-dir: release-tools git-subtree-split: 4967685
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
chore: remove csi-lib-iscsi vendor
there's a plan to move https://github.com/kubernetes-csi/csi-lib-iscsi to be part of https://github.com/kubernetes-csi/csi-driver-iscsi, csi-lib-iscsi repo will be deprecated in the near future
This PR addresses this work item
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @xing-yang @msau42 @humblec
Does this PR introduce a user-facing change?: