master: update release-tools #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes-csi/csi-release-tools@37d11049 Merge kubernetes-csi/csi-release-tools#191 from pohly/go-1.18 kubernetes-csi/csi-release-tools@db917f5c update to Go 1.18 git-subtree-dir: release-tools git-subtree-split: 37d1104
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
There are some CI failures. |
I would have found those earlier if they had been integrated into How do I run those failing tests locally? |
k8s-ci-robot
added
size/S
This might solve problems with Go 1.18. The newer golangci-lint runs more slowly, therefore the timeout gets increased from the default 1m to 5m.
pohly
force-pushed
the
prow-update-master
branch
from
91a86a4 to
ceab9da
Compare
|
The "Trivy vulnerability scanner" failures seem unrelated to this PR. |
|
Same for golangci-lint: it's not using the Go version from prow.sh. |
|
Cc @andyzhangx |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed 'release-tools/' changes from 335339f..37d1104
37d11049 Merge pull request #191 from pohly/go-1.18
db917f5c update to Go 1.18
git-subtree-dir: release-tools
git-subtree-split: 37d1104