WIP: Add 1.15 testing

[msau42]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Updates prow.sh to use 1.15 hostpath deployment. As a result, the kind version also has to be upgraded to 0.4.0, which requires 2 major changes to our prow job:

1. We need to use the new kind.sigs.k8s.io/v1alpha3 Cluster' API object, which uses kubeadm.k8s.io/v1beta2` which only works for 1.15+. As a result, our alpha jobs can only run on 1.15+
2. kind 0.4.0 supports very specific patch images of 1.15, 1.14, 1.13, etc, which are not the ones we have configured in our prow jobs. As a result, I have added logic in the prow job to override the patch versions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[pohly]

There's something odd in the job config: pull-kubernetes-csi-csi-driver-host-path-unit ran with CSI_PROW_TESTS=parallel. It should have execute the unit tests instead. Hmm, this looks right: https://github.com/kubernetes/test-infra/blob/0e3897d9c59bb364c306f671f914c83fc4e401dc/config/jobs/kubernetes-csi/csi-driver-host-path/csi-driver-host-path-config.yaml#L221-L251

Ah, you are overriding that in .prow.sh. That explains it 😄

Kubernetes versions may also have to be updated because kind 0.4.0 only supports specific versions.

Does it still support the ones we care about (1.13, 1.14 and now 1.15)? It shouldn't matter too much which version exactly that is.

Unsure if there's going to be an atomic way to update the version without breaking pull and ci jobs temporarily

It should be atomic: once this PR gets merged, the existing pull and periodic CI jobs will use the config from the updated master branch. We just need to be sure that the updated config also works for them. Once you remove the .prow.sh overrides, we'll test that for the mandatory pull jobs when they run.

What isn't atomic is adding the new 1.15 jobs. One way of doing that is:

• define the new jobs in test-infra without making them mandatory
• run the new pull-kubernetes-csi-csi-driver-host-path-1-15-on-kubernetes-1-15 manually in this PR via the test command
• merge this PR and similar ones for the other sidecars
• update the new jobs to make them mandatory

[msau42]

@pohly kind 0.4.0 only supports 1.15.0, 1.14.3, and 1.13.7, which is different from the versions we configured in our test-infra.

So I think in order to make this switch, we will have to temporarily disable/optional the pull jobs and change the versions in the jobs, so that we can merge this PR. Do you see any better ways to do this?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• release-tools/OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[msau42]

Patrick Ohly kind 0.4.0 only supports 1.15.0, 1.14.3, and 1.13.7, which is different from the versions we configured in our test-infra.

So I think in order to make this switch, we will have to temporarily disable/optional the pull jobs and change the versions in the jobs, so that we can merge this PR. Do you see any better ways to do this?

My last commit attempts to workaround this by overriding the patch versions no matter what. LMK if you think that's acceptable.

[pohly]

My last commit attempts to workaround this by overriding the patch versions no matter what. LMK if you think that's acceptable.

Yes, that's okay. I'm just wondering whether we should change the semantic of CSI_PROW_KUBERNETES_VERSION and make it's value just <major>.<minor>. OTOH, for future, unknown versions that aren't getting patched we still need <major>.<minor>.<patch>. Let's just keep it as-is.

[msau42]

/test pull-kubernetes-csi-csi-driver-host-path-1-15-on-kubernetes-master

[k8s-ci-robot]

@msau42: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-csi-csi-driver-host-path-unit	c78288c	link	/test pull-kubernetes-csi-csi-driver-host-path-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[msau42]

/test pull-kubernetes-csi-csi-driver-host-path-1-15-on-kubernetes-master

[msau42]

/close
Addressed by #70

[k8s-ci-robot]

@msau42: Closed this PR.

In response to this:

/close
Addressed by #70

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.