fix 1 snapshot create a lot of snap file #245

daresheep · 2021-02-04T02:37:16Z

If the file task more then 1 min. other request will create new snap file.

issue:

k8s-ci-robot · 2021-02-04T02:37:17Z

@daresheep: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-02-04T02:37:18Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-02-04T02:37:18Z

@daresheep: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-02-04T02:37:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daresheep
To complete the pull request process, please assign xing-yang after the PR has been reviewed.
You can assign the PR to them by writing /assign @xing-yang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-02-04T02:37:23Z

Welcome @daresheep!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-02-04T02:37:24Z

Hi @daresheep. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

daresheep · 2021-02-04T08:06:27Z

CLA signature

daresheep · 2021-02-06T04:26:54Z

/assign @xing-yang

k8s-ci-robot · 2021-02-24T19:30:04Z

@daresheep: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aayushrangwala · 2021-04-25T11:56:01Z

pkg/hostpath/controllerserver.go

 	snapshot := hostPathSnapshot{}
 	snapshot.Name = req.GetName()
 	snapshot.Id = snapshotID
 	snapshot.VolID = volumeID
 	snapshot.Path = file
 	snapshot.CreationTime = creationTime
 	snapshot.SizeBytes = hostPathVolume.VolSize
+	snapshot.ReadyToUse = false
+	hostPathVolumeSnapshots[snapshotID] = snapshot


This entry is being added below as well :438 which makes more sense there as anyway the snapshot_id is being added to map only after the successful creation.

aayushrangwala · 2021-04-25T11:57:02Z

pkg/hostpath/controllerserver.go

 	snapshot := hostPathSnapshot{}
 	snapshot.Name = req.GetName()
 	snapshot.Id = snapshotID
 	snapshot.VolID = volumeID
 	snapshot.Path = file
 	snapshot.CreationTime = creationTime
 	snapshot.SizeBytes = hostPathVolume.VolSize
+	snapshot.ReadyToUse = false


snapshot.ReadyToUse must be false by default as its a bool with zero value false. There seems to be no need here

aayushrangwala · 2021-04-25T12:18:05Z

pkg/hostpath/controllerserver.go

+		return nil, status.Errorf(codes.Internal, "failed create snapshot: %v: %s", err, out)
+	}
+
+	glog.V(4).Infof("create volume snapshot %s", file)


log is incorrect. It should be Craeted Or misplaced as the actual snapshot is being created where the commands are executed

aayushrangwala · 2021-04-25T12:28:43Z

This overall fix in the PR doesnot seems to make much difference. The issue seems to be there for the large PVs and its entry is not being added to the map and in the next iteration getSnapshotByName() may not be returning anything.

Need to check if the command is executed without error or is it going timeout

k8s-triage-robot · 2021-07-26T20:15:41Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

k8s-triage-robot · 2021-08-25T21:13:46Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2021-09-24T21:43:43Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2021-09-24T21:43:45Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fix 1 snapshot create a lot of snap file

156778e

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 4, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 4, 2021

k8s-ci-robot requested review from msau42 and saad-ali February 4, 2021 02:37

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2021

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 4, 2021

k8s-ci-robot assigned xing-yang Feb 6, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2021

aayushrangwala reviewed Apr 25, 2021

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 25, 2021

k8s-ci-robot closed this Sep 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix 1 snapshot create a lot of snap file #245

fix 1 snapshot create a lot of snap file #245

daresheep commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

daresheep commented Feb 4, 2021

daresheep commented Feb 6, 2021

k8s-ci-robot commented Feb 24, 2021

aayushrangwala Apr 25, 2021

aayushrangwala Apr 25, 2021

aayushrangwala Apr 25, 2021 •

edited

Loading

aayushrangwala commented Apr 25, 2021

k8s-triage-robot commented Jul 26, 2021

k8s-triage-robot commented Aug 25, 2021

k8s-triage-robot commented Sep 24, 2021

k8s-ci-robot commented Sep 24, 2021

fix 1 snapshot create a lot of snap file #245

fix 1 snapshot create a lot of snap file #245

Conversation

daresheep commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

k8s-ci-robot commented Feb 4, 2021

daresheep commented Feb 4, 2021

daresheep commented Feb 6, 2021

k8s-ci-robot commented Feb 24, 2021

aayushrangwala Apr 25, 2021

Choose a reason for hiding this comment

aayushrangwala Apr 25, 2021

Choose a reason for hiding this comment

aayushrangwala Apr 25, 2021 • edited Loading

Choose a reason for hiding this comment

aayushrangwala commented Apr 25, 2021

k8s-triage-robot commented Jul 26, 2021

k8s-triage-robot commented Aug 25, 2021

k8s-triage-robot commented Sep 24, 2021

k8s-ci-robot commented Sep 24, 2021

aayushrangwala Apr 25, 2021 •

edited

Loading