Skip to content

Commit

Permalink
Revert "Add interactive configuration to exec provider."
Browse files Browse the repository at this point in the history
This reverts commit e0dfc6b.
  • Loading branch information
brendandburns authored and yliaog committed Jun 21, 2022
1 parent 59ee365 commit 1ea21da
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions kubernetes/base/config/exec_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,11 @@ def __init__(self, exec_config, cwd):
self.cwd = cwd or None

def run(self, previous_response=None):
is_interactive = sys.stdout.isatty()
kubernetes_exec_info = {
'apiVersion': self.api_version,
'kind': 'ExecCredential',
'spec': {
'interactive': is_interactive
'interactive': sys.stdout.isatty()
}
}
if previous_response:
Expand All @@ -71,8 +70,7 @@ def run(self, previous_response=None):
process = subprocess.Popen(
self.args,
stdout=subprocess.PIPE,
stderr=sys.stderr when is_interactive else subprocess.PIPE,
stdin=sys.stdin when is_interactive else None,
stderr=subprocess.PIPE,
cwd=self.cwd,
env=self.env,
universal_newlines=True)
Expand Down

0 comments on commit 1ea21da

Please sign in to comment.