fix: Fix TypeError of topNodes

[koooge]

Hi there,
This is a fix of topNodes(). It seems to have stopped working due to TypeError since 0.19.x.

TypeError: Cannot read properties of undefined (reading 'Running')
    at path/to/node_modules/@kubernetes/client-node/dist/top.js:61:92
    at Array.filter (<anonymous>)\n
    at Object.topNodes (path/to/node_modules/@kubernetes/client-node/dist/top.js:59:21)
...

[k8s-ci-robot]

Welcome @koooge!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[mstruebing]

Hey. @koooge thank you very much for your PR.
Are you sure this is the fix? When looking at the code and the error message I guess it's more likely the reason that the V1PodStatus class doesn't contain a PhaseEnum anymore. Can you validate?

With your change you should be able to remove the @ts-ignore comment above and the error should pop up.
I think the part after/including the || can just be removed.

[koooge]

Hi @mstruebing , I think you are right! So this is almost the same as reverting 3520057

[mstruebing]

Yea thank you 🙈

/lgtm
/approve

[mstruebing]

/approve

[brendandburns]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, koooge, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hox]

How soon would this be tagged? Currently relying on 0.18.1 APIs and getting blocked from upgrading.