Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for tls-server-name in KubeConfig #1436

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix: add support for tls-server-name in KubeConfig #1436

merged 2 commits into from
Nov 22, 2023

Conversation

stefreak
Copy link
Contributor

@stefreak stefreak commented Nov 21, 2023 •
edited
Loading

The feature that was added in 076531e was missing in the 1.x release branch – we ported the existing feature from there.

@stefreak @TimBeyer
fix: add support for tls-server-name in KubeConfig
60f0ea6 
For some reason the feature that was added in 076531e was missing in the 1.x release branch – we ported the existing feature from there.

Co-authored-by: Tim Beyer <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @stefreak!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2023
@stefreak stefreak mentioned this pull request Nov 21, 2023
Merged
stefreak added a commit to garden-io/garden that referenced this pull request Nov 21, 2023
@stefreak
fix(k8s): read tls-server-name correctly from kubeconfig
3d8588e 
We switch to internal kubernetes-client/javascript fork where we fixed
this issue upstream in commit kubernetes-client/javascript@60f0ea6

See also kubernetes-client/javascript#1436
github-merge-queue bot pushed a commit to garden-io/garden that referenced this pull request Nov 21, 2023
@stefreak
fix(k8s): read tls-server-name correctly from kubeconfig (#5466)
554d964 
We switch to internal kubernetes-client/javascript fork where we fixed
this issue upstream in commit kubernetes-client/javascript@60f0ea6

See also kubernetes-client/javascript#1436
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks for the PR (and especially for adding unit tests!)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2023
View reviewed changes
src/config_test.ts Dismissed Show dismissed Hide dismissed
@mstruebing
Copy link
Member

/lgtm
/approve

Thank you 🙏

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, mstruebing, stefreak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mstruebing
Copy link
Member

@stefreak If you run rpm run format it should fix the code style issues and the pipeline should succeed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2023
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 22, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: stefreak / name: Steffen Neubauer (60f0ea6)
  • ✅ login: TimBeyer / name: Tim Beyer (2873788)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 22, 2023
@mstruebing
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 633147f into kubernetes-client:release-1.x Nov 22, 2023
5 checks passed
@stefreak stefreak mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@drubin drubin Awaiting requested review from drubin

Assignees

@brendandburns brendandburns

@mstruebing mstruebing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stefreak @k8s-ci-robot @brendandburns @mstruebing @TimBeyer