Merge pull request #3627 from Babak-abd/babak-optional-3rdParty-ignored

optional 3rd party ignored (issue #3596)
kubernetes-client · Aug 13, 2024 · b87fb0b · b87fb0b
2 parents e9e992a + 3601df9
commit b87fb0b
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 10 deletions.
diff --git a/extended/pom.xml b/extended/pom.xml
@@ -34,6 +34,11 @@
             <artifactId>client-java-api-fluent</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>io.prometheus</groupId>
+            <artifactId>simpleclient</artifactId>
+            <optional>${prometheus.client.optional}</optional>
+        </dependency>
         <dependency>
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-lang3</artifactId>

diff --git a/fluent-gen/pom.xml b/fluent-gen/pom.xml
@@ -10,7 +10,7 @@
   <parent>
     <groupId>io.kubernetes</groupId>
     <artifactId>client-java-parent</artifactId>
-    <version>21.0.0-legacy-SNAPSHOT</version>
+    <version>21.0.1-legacy-SNAPSHOT</version>
     <relativePath>../pom.xml</relativePath>
   </parent>
 

diff --git a/pom.xml b/pom.xml
@@ -69,6 +69,17 @@
     <prometheus.client.version>0.16.0</prometheus.client.version>
     <reflections.version>0.10.2</reflections.version>
 
+    <!-- The `optional` tag in `dependencyManagement` is not inherited; see
+    https://issues.apache.org/jira/browse/MNG-5227 and
+    https://issues.apache.org/jira/browse/MNG-5632. Therefore, we specify
+    optional dependencies here to manage them in a single location. -->
+    <prometheus.client.optional>true</prometheus.client.optional>
+    <com.amazonaws.aws-java-sdk-sts.optional>true</com.amazonaws.aws-java-sdk-sts.optional>
+    <com.google.auth.google-auth-library-oauth2-http.optional>true</com.google.auth.google-auth-library-oauth2-http.optional>
+    <org.springframework.boot.spring-boot-actuator.optional>true</org.springframework.boot.spring-boot-actuator.optional>
+    <com.microsoft.azure.adal4j.optional>true</com.microsoft.azure.adal4j.optional>
+    <com.fasterxml.jackson.core.jackson-annotations.optional>true</com.fasterxml.jackson.core.jackson-annotations.optional>
+
     <e2e.skip>true</e2e.skip>
 
     <gpg.keyname>48540ECBBF00A28EACCF04E720FD12AFB0C9EBA9</gpg.keyname>
@@ -143,13 +154,13 @@
         <groupId>com.microsoft.azure</groupId>
         <artifactId>adal4j</artifactId>
         <version>1.6.7</version>
-        <optional>true</optional>
+        <optional>${com.microsoft.azure.adal4j.optional}</optional>
       </dependency>
       <dependency>
         <groupId>com.amazonaws</groupId>
         <artifactId>aws-java-sdk-sts</artifactId>
         <version>1.12.746</version>
-        <optional>true</optional>
+        <optional>${com.amazonaws.aws-java-sdk-sts.optional}</optional>
       </dependency>
       <dependency>
         <groupId>com.google.protobuf</groupId>
@@ -185,19 +196,16 @@
         <groupId>org.springframework.boot</groupId>
         <artifactId>spring-boot-actuator</artifactId>
         <version>${spring.boot.version}</version>
-        <optional>true</optional>
       </dependency>
       <dependency>
         <groupId>io.prometheus</groupId>
         <artifactId>simpleclient</artifactId>
         <version>${prometheus.client.version}</version>
-        <optional>true</optional>
       </dependency>
       <dependency>
         <groupId>io.prometheus</groupId>
         <artifactId>simpleclient_httpserver</artifactId>
         <version>${prometheus.client.version}</version>
-        <optional>true</optional>
       </dependency>
       <dependency>
         <groupId>com.google.code.gson</groupId>
@@ -248,13 +256,13 @@
         <groupId>com.google.auth</groupId>
         <artifactId>google-auth-library-oauth2-http</artifactId>
         <version>1.23.0</version>
-        <optional>true</optional>
+        <optional>${com.google.auth.google-auth-library-oauth2-http.optional}</optional>
       </dependency>
       <dependency>
         <groupId>com.fasterxml.jackson.core</groupId>
         <artifactId>jackson-annotations</artifactId>
         <version>2.17.1</version>
-        <optional>true</optional>
+        <optional>${com.fasterxml.jackson.core.jackson-annotations.optional}</optional>
       </dependency>
 
       <!-- tests -->

diff --git a/spring/pom.xml b/spring/pom.xml
@@ -26,7 +26,11 @@
       <artifactId>client-java-extended</artifactId>
       <version>${project.version}</version>
     </dependency>
-
+    <dependency>
+      <groupId>io.prometheus</groupId>
+      <artifactId>simpleclient</artifactId>
+      <optional>${prometheus.client.optional}</optional>
+    </dependency>
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot</artifactId>
@@ -38,6 +42,7 @@
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot-actuator</artifactId>
+      <optional>${org.springframework.boot.spring-boot-actuator.optional}</optional>
     </dependency>
     <dependency>
       <groupId>com.github.ben-manes.caffeine</groupId>

diff --git a/util/pom.xml b/util/pom.xml
@@ -15,10 +15,12 @@
         <dependency>
             <groupId>io.prometheus</groupId>
             <artifactId>simpleclient</artifactId>
+            <optional>${prometheus.client.optional}</optional>
         </dependency>
         <dependency>
             <groupId>io.prometheus</groupId>
             <artifactId>simpleclient_httpserver</artifactId>
+            <optional>${prometheus.client.optional}</optional>
         </dependency>
         <dependency>
             <groupId>io.kubernetes</groupId>
@@ -65,6 +67,7 @@
         <dependency>
             <groupId>com.amazonaws</groupId>
             <artifactId>aws-java-sdk-sts</artifactId>
+            <optional>${com.amazonaws.aws-java-sdk-sts.optional}</optional>
         </dependency>
         <dependency>
             <groupId>ch.qos.logback</groupId>
@@ -86,7 +89,7 @@
         <dependency>
             <groupId>com.google.auth</groupId>
             <artifactId>google-auth-library-oauth2-http</artifactId>
-            <optional>true</optional>
+            <optional>${com.google.auth.google-auth-library-oauth2-http.optional}</optional>
         </dependency>
         <!-- test dependencies -->
         <dependency>