Merge pull request #2046 from yaohui-wyh/master

Fix arrayIndexOutOfBounds exception for overloaded addModelMap method
kubernetes-client · Dec 24, 2021 · 621e23d · 621e23d
2 parents d03c36a + 482b2b7
commit 621e23d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/util/src/main/java/io/kubernetes/client/util/ModelMapper.java b/util/src/main/java/io/kubernetes/client/util/ModelMapper.java
@@ -89,10 +89,11 @@ public class ModelMapper {
   @Deprecated
   public static void addModelMap(String apiGroupVersion, String kind, Class<?> clazz) {
     String[] parts = apiGroupVersion.split("/");
-    if (parts.length == 1) { // legacy api group
+    if (parts.length <= 1) { // legacy api group
       addModelMap("", apiGroupVersion, kind, clazz);
+    } else {
+      addModelMap(parts[0], parts[1], kind, clazz);
     }
-    addModelMap(parts[0], parts[1], kind, clazz);
   }
 
   /**

diff --git a/util/src/test/java/io/kubernetes/client/util/ModelMapperTest.java b/util/src/test/java/io/kubernetes/client/util/ModelMapperTest.java
@@ -51,6 +51,11 @@ public void testAddingModel() {
 
     assertNull(ModelMapper.getApiTypeClass("example.io/v1", "Tofu"));
     assertNull(ModelMapper.getApiTypeClass("example.io", "v1", "Tofu"));
+
+    assertNull(ModelMapper.getApiTypeClass("v1", "Togu"));
+    ModelMapper.addModelMap("v1", "Togu", objClass);
+    assertEquals(objClass, ModelMapper.getApiTypeClass("", "v1", "Togu"));
+    assertEquals(objClass, ModelMapper.getApiTypeClass("v1", "Togu"));
   }
 
   @Test