Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Enhancements #794

Merged
merged 4 commits into from
Mar 8, 2022
Merged

Code Enhancements #794

merged 4 commits into from
Mar 8, 2022

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Mar 8, 2022

  • Keep private members readonly in StringTokenProvider
  • Use long.TryParse instead of int.TryParse
  • Sealed internal types(maybe we could enforce this with some analyzer)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2022
@tg123
Copy link
Member

tg123 commented Mar 8, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2022
@WeihanLi WeihanLi requested a review from tg123 March 8, 2022 01:44
tg123
tg123 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tg123, WeihanLi
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tg123 tg123 merged commit f69bf83 into kubernetes-client:master Mar 8, 2022
@WeihanLi WeihanLi deleted the code-enhancement branch March 9, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@tg123 tg123

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WeihanLi @tg123 @k8s-ci-robot